Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM fix for MML issue where Partial Wing not accounted for #5440

Merged
merged 2 commits into from
May 2, 2024
Merged

MM fix for MML issue where Partial Wing not accounted for #5440

merged 2 commits into from
May 2, 2024

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented May 1, 2024

Adds PW Jump MP accounting outside of games so MML stats are correct.

Testing:

  • Ran MM and MML unit tests (MHQ currently broken)
  • Tested with Kage suits in MML and verified correct Jump MP with and without Partial Wing
  • Tested with Kage suits in MM and verified correct Jump MP with atmosphere and without.

Close #5439

@Sleet01 Sleet01 requested a review from kuronekochomusuke May 1, 2024 20:44
@Sleet01 Sleet01 merged commit 9cf798b into MegaMek:master May 2, 2024
4 checks passed
@Sleet01 Sleet01 mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SJuliez SJuliez SJuliez left review comments

@kuronekochomusuke kuronekochomusuke Awaiting requested review from kuronekochomusuke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BA Jump MP bonus from Partial Wing only visible in-game with suitable atmosphere
3 participants
@Sleet01 @SJuliez @kuronekochomusuke